Skip to content

Conversation

@josephaxisa
Copy link
Contributor

make the call fix

Also replaced deprecated Tabs components in DocMultiCall with Tabs2
@josephaxisa josephaxisa requested a review from jkaster October 28, 2021 10:15
@google-cla google-cla bot added the cla: yes label Oct 28, 2021
@github-actions
Copy link
Contributor

APIX Tests

0 files   -     1  0 suites   - 77   0s ⏱️ - 3m 16s
0 tests  - 317  0 ✔️  - 304  0 💤  - 13  0 ❌ ±0 
0 runs   - 333  0 ✔️  - 320  0 💤  - 13  0 ❌ ±0 

Results for commit ef6fe72. ± Comparison against base commit 0895f80.

This pull request removes 317 tests.
 DocTitle renders a heading with title prop content ‑  DocTitle renders a heading with title prop content
 MethodBadge renders with the provided verb ‑  MethodBadge renders with the provided verb
ApiSpecSelector it fires a SELECT_SPEC action when another spec is selected ‑ ApiSpecSelector it fires a SELECT_SPEC action when another spec is selected
ApiSpecSelector it lists all available specs ‑ ApiSpecSelector it lists all available specs
ApiSpecSelector the default spec is selected by default ‑ ApiSpecSelector the default spec is selected by default
CodeCopy displays code and clipboard UI ‑ CodeCopy displays code and clipboard UI
CodeDisplay it highlights text matching search pattern ‑ CodeDisplay it highlights text matching search pattern
CodeDisplay it syntax highlights ‑ CodeDisplay it syntax highlights
CodeDisplay utils it can syntax highlight all supported sdk langs ‑ CodeDisplay utils it can syntax highlight all supported sdk langs
CodeDisplay utils it highlights as markup for unsupported/undefined language ‑ CodeDisplay utils it highlights as markup for unsupported/undefined language
…

@josephaxisa josephaxisa changed the title fix: catch complex structure errors when generating sdk call syntax and show useful message fix: show a helpful message when sdk call syntax generation fails Oct 28, 2021
@github-actions
Copy link
Contributor

APIX Tests

    1 files  ±0    77 suites  ±0   3m 3s ⏱️ -13s
318 tests +1  305 ✔️ +1  13 💤 ±0  0 ❌ ±0 
334 runs  +1  321 ✔️ +1  13 💤 ±0  0 ❌ ±0 

Results for commit 819207a. ± Comparison against base commit 0895f80.

Copy link

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephaxisa josephaxisa merged commit 1e9348b into main Oct 28, 2021
@josephaxisa josephaxisa deleted the jax/fix-call-gen-errors branch October 28, 2021 15:53
@github-actions

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants