fix: Hackathon styling and resource update #884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated Loading component to default to always display if not passed in loading prop. Making it as dumb as possible - Updated Loading rendering logic and styling in scene components so layouts does not shift/change after loading is finished. - Updated side nav to be thinner to accomodate smaller viewports - Updated resources with new component and dataset tag - Added header to each page for easier navigability - Added hacker faq link to home/agenda page - Added additional text and field styling to resource page for better UX
jeremytchang
commented
Oct 29, 2021
| <Heading as="h2" fontSize="xxxlarge" fontWeight="medium"> | ||
| Agenda | ||
| </Heading> | ||
| <Span> |
Collaborator
Author
There was a problem hiding this comment.
Nested in span so the paragraph is not too far from Heading in SpaceVertical.
There was a problem hiding this comment.
For v.next with artifact storage we'll schedule some design review too
Collaborator
Author
There was a problem hiding this comment.
Totally. I'm pretty sure I'm not following design best practices here, only aiming for what looks good. Will appreciate their input.
jkaster
approved these changes
Oct 29, 2021
jkaster
left a comment
jkaster
left a comment
There was a problem hiding this comment.
Lots of nice little improvements. Good sweep.
| <Heading as="h2" fontSize="xxxlarge" fontWeight="medium"> | ||
| Agenda | ||
| </Heading> | ||
| <Span> |
There was a problem hiding this comment.
For v.next with artifact storage we'll schedule some design review too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
passed in loading prop. Making it as dumb as possible
so layouts does not shift/change after loading is finished.
better UX