feat: judging view for Hackathon app #891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkaster
requested review from
bryans99,
jeremytchang,
josephaxisa and
lanlooker
jeremytchang
reviewed
Nov 3, 2021
packages/hackathon/src/scenes/JudgingEditorScene/components/JudgingViewDialog.tsx
Show resolved
Hide resolved
jeremytchang
reviewed
Nov 3, 2021
| */ | ||
|
|
||
| export * from './ProjectView' | ||
| import type { ITechnologyProps } from '../../../models' |
Collaborator
There was a problem hiding this comment.
This file should be moved up a folder or two since its shared between projects and judging scene.
jeremytchang
previously approved these changes
Nov 3, 2021
Collaborator
jeremytchang
left a comment
jeremytchang
left a comment
There was a problem hiding this comment.
LGTM. Thanks! Looks great! :D
jeremytchang
previously approved these changes
Nov 3, 2021
Collaborator
jeremytchang
left a comment
jeremytchang
left a comment
There was a problem hiding this comment.
LGTM.
Typically you dont need to comment the onClose handler. Prefixing on, pretty much means its an event handler. But thank you for heeding the feedback!
jeremytchang
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Removed
Screenshots
Judging View
Project View