-
Notifications
You must be signed in to change notification settings - Fork 197
feat: disable "Add Project" when judging starts #894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jeremytchang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We still have to lock projects when judging time comes. Ideally this should all be consolidated into one automatic flow, where when judging time starts, projects are auto locked and projects additions is stopped for hackers. These flows would not apply for staff and admin.
jeremytchang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with changes.
jeremytchang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote up an example of what the code could be.
Also moved the text to after the button. From previous frontend work, typically statuses appear after the button, so the button is not shifted when status changes (though that doesn't apply in this case, since the button will never shift). It also reads better, from left to right. You see the Add button disabled, then you read the status or reason for it.
# Conflicts: # packages/hackathon/src/scenes/HomeScene/HomeScene.tsx
jeremytchang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jeremytchang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Judging time for the hackathon is always shown at the bottom of the project list now
If judging has started:
Add ProjectbuttonAdd Projectremains enabledAdd Projectis disabledMade intro agenda on the home page display English or Japanese depending on the user's locale
Screenshots
Regular hackathon attendee
User who can lock projects