Skip to content

Conversation

@jkaster
Copy link

@jkaster jkaster commented Nov 8, 2021

  • Judging time for the hackathon is always shown at the bottom of the project list now

  • If judging has started:

    • the judging start time is displayed to the left of the Add Project button
    • if the user has the ability to lock projects, Add Project remains enabled
    • if the user is a regular hackathon attendee, Add Project is disabled
  • Made intro agenda on the home page display English or Japanese depending on the user's locale

Screenshots

Regular hackathon attendee

image

User who can lock projects

image

@jkaster jkaster requested a review from jeremytchang November 8, 2021 21:12
@google-cla google-cla bot added the cla: yes label Nov 8, 2021
Copy link
Collaborator

@jeremytchang jeremytchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We still have to lock projects when judging time comes. Ideally this should all be consolidated into one automatic flow, where when judging time starts, projects are auto locked and projects additions is stopped for hackers. These flows would not apply for staff and admin.

Copy link
Collaborator

@jeremytchang jeremytchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with changes.

@jkaster jkaster requested a review from jeremytchang November 8, 2021 23:10
Copy link
Collaborator

@jeremytchang jeremytchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote up an example of what the code could be.

Also moved the text to after the button. From previous frontend work, typically statuses appear after the button, so the button is not shifted when status changes (though that doesn't apply in this case, since the button will never shift). It also reads better, from left to right. You see the Add button disabled, then you read the status or reason for it.

https://github.com/looker-open-source/sdk-codegen/blob/jc/add_project_example/packages/hackathon/src/scenes/ProjectsScene/ProjectsScene.tsx

jeremytchang
jeremytchang previously approved these changes Nov 9, 2021
Copy link
Collaborator

@jeremytchang jeremytchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@jeremytchang jeremytchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkaster jkaster merged commit d3386ae into main Nov 9, 2021
@jkaster jkaster deleted the jk/add_project_disabling branch November 9, 2021 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants