Conversation
Adds the 'Add xDrip4iOS as a CGM' customization to CustomizationSelect. Customizations that introduce a new submodule (such as xdrip_cgm, which adds xdrip-client-swift) now take an optional sixth add_customization argument with the submodule path. After such a patch is applied, the referenced repository is cloned using the URL the patch added to .gitmodules, so the Xcode project it references exists; reverting the customization removes the cloned directory. Existing source-only customizations are unaffected. Regenerated CustomizationSelect.sh from src.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add the Add xDrip4iOS as a CGM customization to CustomizationSelect, and add support for customizations that introduce a new submodule.
Pairs with the patch in loopandlearn/customization#65 (branch
xdrip_cgm).Method
add_customization "Add xDrip4iOS as a CGM (clones xdrip-client-swift)" "xdrip_cgm" ...add_customizationgains an optional sixth argument: the path of a submodule the customization adds. When present, after the patch applies the script clones that repository using the URL the patch added to.gitmodules(so the referenced Xcode project exists), and removes the directory when the customization is reverted. This mirrors how the GitHub-action build clonesxdrip-client-swift.CustomizationSelect.shfromsrc/.Dependency
The patch itself lives in loopandlearn/customization#65. The test commands below fetch this branch's
CustomizationSelect.shand pointPATCH_BRANCHat the matching customization branch.Test
reset command
apply
Confirm the patch applies,
xdrip-client-swift/is cloned,xdrip-client-swift/xDripClient.xcodeprojexists, and that reverting the customization both reverses the patch and removes the cloned directory.