From 2e035a539a5c0e72578bd8af5132f7f8a23379e6 Mon Sep 17 00:00:00 2001
From: Raymond Feng <enjoyjava@gmail.com>
Date: Tue, 12 Feb 2019 12:32:45 -0800
Subject: [PATCH] fix(cli): do not install deps for built-in connectors

---
 packages/cli/generators/datasource/index.js                 | 6 ++++--
 .../test/integration/generators/datasource.integration.js   | 1 +
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/packages/cli/generators/datasource/index.js b/packages/cli/generators/datasource/index.js
index 141894401a7c..1434b7c1192b 100644
--- a/packages/cli/generators/datasource/index.js
+++ b/packages/cli/generators/datasource/index.js
@@ -311,8 +311,10 @@ module.exports = class DataSourceGenerator extends ArtifactGenerator {
       debug(`npmModule - ${pkgs[0]}`);
     } else {
       const connectorName = this.artifactInfo.connector;
-      // Other connectors
-      if (!deps[connectorName]) pkgs.push(connectorName);
+      // Other connectors that are not listed in `connectors.json`.
+      // No install is needed for those in connectors.json but without a
+      // package name as they are built-in connectors
+      if (!deps[connectorName] && !connector) pkgs.push(connectorName);
     }
 
     if (!deps['@loopback/repository']) {
diff --git a/packages/cli/test/integration/generators/datasource.integration.js b/packages/cli/test/integration/generators/datasource.integration.js
index 8aa44663cd34..31c820e88527 100644
--- a/packages/cli/test/integration/generators/datasource.integration.js
+++ b/packages/cli/test/integration/generators/datasource.integration.js
@@ -157,6 +157,7 @@ function checkBasicDataSourceFiles() {
   assert.file(expectedTSFile);
   assert.file(expectedJSONFile);
   assert.file(expectedIndexFile);
+  assert.noFile(path.join(SANDBOX_PATH, 'node_modules/memory'));
 
   assert.fileContent(expectedTSFile, /import {inject} from '@loopback\/core';/);
   assert.fileContent(