From 4c6b1768279f6d0d0081e6fe10f5def3463ea8b3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miroslav=20Bajto=C5=A1?= Date: Fri, 25 Jan 2019 08:40:11 +0100 Subject: [PATCH] docs: fix instructions for verifying TypeScript setup --- docs/site/DEVELOPING.md | 6 +----- docs/site/VSCODE.md | 6 ++---- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/docs/site/DEVELOPING.md b/docs/site/DEVELOPING.md index 1de5c87348c9..5445b2170970 100644 --- a/docs/site/DEVELOPING.md +++ b/docs/site/DEVELOPING.md @@ -466,7 +466,7 @@ configuration, it's important to verify that all usage scenarios keep working. ### Verify TypeScript setup -1. Open any existing TypeScript file, e.g. `packages/src/index.ts` +1. Open any existing TypeScript file, e.g. `packages/core/src/index.ts` 2. Add a small bit of code to break TypeScript's type checks, for example: @@ -479,10 +479,6 @@ configuration, it's important to verify that all usage scenarios keep working. 4. Verify that the build failed and the compiler error message shows a path relative to monorepo root, e.g. `packages/src/index.ts`. - _(This is does not work now, `tsc` is reporting paths relative to individual - package directories. See - )_ - 5. Test integration with supported IDEs: - [VS Code](./VSCODE.md#how-to-verify-typescript-setup) diff --git a/docs/site/VSCODE.md b/docs/site/VSCODE.md index 79d680c23604..8b3d3d6026e1 100644 --- a/docs/site/VSCODE.md +++ b/docs/site/VSCODE.md @@ -20,7 +20,7 @@ Our monorepo comes with few preconfigured ### Compilation errors -1. Open any existing TypeScript file, e.g. `packages/src/index.ts` +1. Open any existing TypeScript file, e.g. `packages/core/src/index.ts` 2. Add a small bit of code to break TypeScript's type checks, for example: @@ -51,9 +51,7 @@ Our monorepo comes with few preconfigured VSCode. 8. Verify that compilation errors are correctly associated with the problematic - source code line. _(This is does not work now, `tsc` is reporting paths - relative to individual package directories. See - )_ + source code line. ### Navigation in VS Code