From 67336104f44784f7c1f63d6758fc5e1319de413b Mon Sep 17 00:00:00 2001 From: Raymond Feng Date: Wed, 22 May 2019 22:47:38 -0700 Subject: [PATCH] fix(cli): clean up template for life cycle observers --- .../cli/generators/observer/templates/observer-template.ts.ejs | 3 +-- .../cli/test/integration/generators/observer.integration.js | 2 ++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/cli/generators/observer/templates/observer-template.ts.ejs b/packages/cli/generators/observer/templates/observer-template.ts.ejs index 155f2552a0df..a7b95c53b04c 100644 --- a/packages/cli/generators/observer/templates/observer-template.ts.ejs +++ b/packages/cli/generators/observer/templates/observer-template.ts.ejs @@ -1,7 +1,6 @@ import { /* inject, Application, CoreBindings, */ lifeCycleObserver, // The decorator - CoreTags, LifeCycleObserver, // The interface } from '@loopback/core'; @@ -28,6 +27,6 @@ export class <%= className %> implements LifeCycleObserver { * This method will be invoked when the application stops */ async stop(): Promise { - // Add your logic for start + // Add your logic for stop } } diff --git a/packages/cli/test/integration/generators/observer.integration.js b/packages/cli/test/integration/generators/observer.integration.js index 7a3d750f338a..1c91b7e5fc0f 100644 --- a/packages/cli/test/integration/generators/observer.integration.js +++ b/packages/cli/test/integration/generators/observer.integration.js @@ -81,6 +81,8 @@ function verifyGeneratedScript(group = '') { ); assert.fileContent(expectedFile, `@lifeCycleObserver('${group}')`); assert.fileContent(expectedFile, /async start\(\): Promise\ {/); + assert.fileContent(expectedFile, /\/\/ Add your logic for start/); + assert.fileContent(expectedFile, /\/\/ Add your logic for stop/); assert.fileContent(expectedFile, /async stop\(\): Promise\ {/); assert.file(INDEX_FILE); assert.fileContent(INDEX_FILE, /export \* from '.\/my-observer.observer';/);