fix(example-rpc-server): mocha opts, mark as private #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the new "mocha.opts" instead of no-longer-available "mocha.ts.opts"
|
I added another commit to mark the rpc-server example as private, see @raymondfeng's #917 |
bajtos
changed the title
Set `private` flag in package.json so that `lerna publish` won't push it to npm.
bajtos
force-pushed
the
fix/example-rpc-server-mocha-opts
branch
from
ea68a77
to
790f621
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new "mocha.opts" instead of no-longer-available "mocha.ts.opts".
This is a follow-up for recently-landed #917, see also #836
cc @kjdelisle @virkt25
Checklist
npm testpasses on your machinepackages/cliwere updatedpackages/example-*were updated