Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add exit option to mocharc template in generator #6475

Merged
merged 1 commit into from Oct 1, 2020

Conversation

simlt
Copy link
Contributor

@simlt simlt commented Sep 30, 2020

Add exit option to mocharc.json template in generator cli.

Ref #2403

Signed-off-by: Simon Mezzomo simlt@users.noreply.github.com

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

馃憠 Check out how to submit a PR 馃憟

Signed-off-by: Simon Mezzomo <simlt@users.noreply.github.com>
bajtos
bajtos approved these changes Oct 1, 2020
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent 馃憦馃徎

Thank you @simlt for the contribution! 鉂わ笍

@bajtos bajtos merged commit 64dbbde into loopbackio:master Oct 1, 2020
2 checks passed
@simlt simlt deleted the feat/mocha-exit branch October 1, 2020 17:11
@bajtos bajtos linked an issue Oct 2, 2020 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor: mocha never finishes because it no longer receives the --exit option
2 participants