Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

this.definition.idName is not a function #6640

Merged
merged 1 commit into from Oct 26, 2020
Merged

this.definition.idName is not a function #6640

merged 1 commit into from Oct 26, 2020

Conversation

frbuceta
Copy link
Contributor

Fixes #5812

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

馃憠 Check out how to submit a PR 馃憟

Signed-off-by: Francisco Buceta <frbuceta@gmail.com>
Copy link
Contributor

@jannyHou jannyHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @frbuceta , the fix and test looks reasonable to me 馃憤

@dhmlau dhmlau merged commit 4ae5069 into master Oct 26, 2020
2 checks passed
@dhmlau dhmlau deleted the fix/issue-5812 branch October 26, 2020 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

save method throws error "this.definition.idName is not a function"
5 participants