Skip to content

fix: better responsive transition of toolbar #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hacksparrow merged 1 commit into from
Aug 26, 2020
Merged

fix: better responsive transition of toolbar #1056

hacksparrow merged 1 commit into from
Aug 26, 2020

Conversation

@hacksparrow
Copy link
Contributor

@hacksparrow hacksparrow commented Aug 24, 2020

Fixes #1005.

BEFORE
before

AFTER
after

fix: better responsive transition of toolbar
c9900d3 
Fixed broken toolbar in some screen sizes.
Signed-off-by: Yaapa Hage <hage.yaapa@in.ibm.com>
@hacksparrow hacksparrow requested a review from dhmlau as a code owner August 24, 2020 16:46
@hacksparrow hacksparrow self-assigned this Aug 24, 2020
@raymondfeng
Copy link
Contributor

raymondfeng commented Aug 24, 2020

I'm curious what's behind 991px over 768px.

@hacksparrow
Copy link
Contributor Author

hacksparrow commented Aug 25, 2020

@raymondfeng The side menu is progammed to adjust for smaller screens (from 991px onwards) by jumping to the top of the page. The navigation bar also does similar adjustments, but from 768px onwards, instead of 991px - they are not in sync. This PR makes the navigation bar to start adjusting itself from 991px onwards.

I also explored the option of doing this adjustment from 768px, but the content of the navigation bar is too much to be contained within 768px, so 991px it is.

dhmlau
dhmlau approved these changes Aug 25, 2020
View reviewed changes
Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on my laptop, and seems to be working.
Haven't got a chance to try it on the phone.

@hacksparrow
Copy link
Contributor Author

hacksparrow commented Aug 26, 2020

@dhmlau do you want to wait till confirming on the phone? It should just work.

@dhmlau
Copy link
Member

dhmlau commented Aug 26, 2020

If you've verified it on the phone, please feel free to land the PR. Thanks.

@hacksparrow hacksparrow merged commit f5e6319 into gh-pages Aug 26, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix/responsive-toolbar branch August 26, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhmlau dhmlau dhmlau approved these changes

Assignees

@hacksparrow hacksparrow

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

loopback.io header not collapsed for mobile

4 participants

@hacksparrow @raymondfeng @dhmlau