refactor: Update times constructor.

Signed-off-by: Pol Dellaiera <pol.dellaiera@protonmail.com>
loophp · Oct 11, 2020 · 3cec95a · 3cec95a
1 parent ca75d99
commit 3cec95a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/spec/loophp/collection/CollectionSpec.php b/spec/loophp/collection/CollectionSpec.php
@@ -8,7 +8,6 @@
 use Closure;
 use Exception;
 use Generator;
-use InvalidArgumentException;
 use Iterator;
 use JsonSerializable;
 use loophp\collection\Collection;
@@ -2629,8 +2628,7 @@ public function it_can_use_times_with_a_callback(): void
             ->shouldIterateAs($a);
 
         $this::times(-1, 'count')
-            ->shouldThrow(InvalidArgumentException::class)
-            ->during('all');
+            ->shouldIterateAs([]);
     }
 
     public function it_can_use_times_without_a_callback(): void
@@ -2639,11 +2637,16 @@ public function it_can_use_times_without_a_callback(): void
             ->shouldIterateAs(range(1, 10));
 
         $this::times(-5)
-            ->shouldThrow(InvalidArgumentException::class)
-            ->during('all');
+            ->shouldIterateAs([]);
 
         $this::times(1)
             ->shouldIterateAs([1]);
+
+        $this::times(0)
+            ->shouldIterateAs([]);
+
+        $this::times()
+            ->shouldIterateAs([]);
     }
 
     public function it_can_use_with(): void

diff --git a/src/Operation/Times.php b/src/Operation/Times.php
@@ -6,7 +6,6 @@
 
 use Closure;
 use Generator;
-use InvalidArgumentException;
 use Iterator;
 
 /**
@@ -42,7 +41,7 @@ static function (?callable $callback = null) use ($number): Closure {
                              */
                             static function (?Iterator $iterator = null) use ($number, $callback): Generator {
                                 if (1 > $number) {
-                                    throw new InvalidArgumentException('Invalid parameter. $number must be greater than 1.');
+                                    yield from [];
                                 }
 
                                 $callback = $callback ?? static function (int $value): int {