Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Transformations into Operations #12

Closed
wants to merge 23 commits into from

Conversation

drupol
Copy link
Collaborator

@drupol drupol commented Aug 10, 2020

This PR

  • Simplify the whole codebase
  • Remove Transformation Interface
  • Convert all Transformations into Operations.
  • Provide 2 types of Operations: EagerOperation and LazyOperation.
  • Let Operations provide how to run their callbacks through Operation::call()
  • Find better naming for AbstractOperation, AbstractLazyOperation, AbstractEagerOperation.

@drupol drupol force-pushed the convert-transformations-into-operations branch from 576aa7a to 997da99 Compare August 10, 2020 19:40
@drupol drupol changed the title Convert transformations into operations Convert Transformations into Operations Aug 10, 2020
@drupol drupol force-pushed the convert-transformations-into-operations branch 2 times, most recently from ea1469e to 709735f Compare August 12, 2020 12:02
@drupol drupol force-pushed the convert-transformations-into-operations branch from 709735f to 75daeea Compare August 12, 2020 12:10
@drupol drupol force-pushed the convert-transformations-into-operations branch from 75daeea to dd6d03f Compare August 12, 2020 12:19
@github-actions
Copy link

Since this pull request has not had any activity within the last 5 days, I have marked it as stale.
I will close it if no further activity occurs within the next 5 days.

@github-actions github-actions bot added the stale label Aug 19, 2020
@drupol drupol force-pushed the convert-transformations-into-operations branch from e48e728 to 7484cfe Compare August 21, 2020 13:41
@drupol drupol removed the stale label Aug 21, 2020
@drupol drupol force-pushed the master branch 2 times, most recently from 77b7871 to 5a7e41d Compare August 22, 2020 18:38
@drupol drupol force-pushed the convert-transformations-into-operations branch from 7484cfe to 92eee00 Compare August 22, 2020 19:34
@drupol
Copy link
Collaborator Author

drupol commented Aug 26, 2020

Closing this in favor of #18

@drupol drupol closed this Aug 26, 2020
@drupol drupol deleted the convert-transformations-into-operations branch August 26, 2020 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant