Skip to content

Channels should have some way to determine if they can send the notification #19

@kevinrenskers

Description

@kevinrenskers

Good example: the EmailChannel needs the recipient to have an email property. This is not checked anywhere, send_notification simply calls process on all enabled channels, which in turn will call send_now, or leave it for send_notification_digests to call send_digest.

The process function should probably call some sort of should_send method. Yes, we have NotificationType.should_save but that's not exactly the same, as it's for the entire notification, not per channel.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions