Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang version to 1.18 #92

Merged
merged 2 commits into from
Mar 18, 2022
Merged

Conversation

soulteary
Copy link
Contributor

No description provided.

@looterz looterz merged commit f583b9b into looterz:master Mar 18, 2022
@soulteary
Copy link
Contributor Author

@looterz wow ,I didn't even have time to write an issue with a clear purpose...

@looterz
Copy link
Owner

looterz commented Mar 18, 2022

Sorry about that, was a bit quick on the gun on mobile - been meaning to update to 1.18 for awhile now

@soulteary
Copy link
Contributor Author

Here is an additional explanation why the version of x/sys was upgraded, Avoid confusion for latecomers.

After the upgrade of golang 1.18, it will cause the project to fail to start on macOS.

google/go-jsonnet#596

Currently, this problem has been officially corrected earlier. like this:

golang/go#49219

Simply put, if we encounter this kind of problem, we only need to execute

go get -u golang.org/x/sys

That's it, no side effects

@soulteary
Copy link
Contributor Author

Sorry I didn't explain clearly.

I think I should follow the rules and submit issues first, then PRs.

I'm actually quite happy because you didn't even need me to explain why you upgraded to go 1.18 and made changes to a module, thank you for your trust. @looterz 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants