Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleans HTML before setting document.title #946

Merged
merged 1 commit into from Jan 28, 2018

Conversation

Projects
None yet
2 participants
@justsml
Copy link
Contributor

justsml commented Jan 27, 2018

Fixes #945

@lord lord changed the base branch from master to dev Jan 28, 2018

@lord

This comment has been minimized.

Copy link
Owner

lord commented Jan 28, 2018

Looks great, thanks so much!

@lord lord merged commit dd8e04c into lord:dev Jan 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@justsml

This comment has been minimized.

Copy link
Contributor Author

justsml commented Jan 29, 2018

Awesome, glad I could help 👍.

Love your project! I built www.fpromises.io with it.

It has an auto-runkit live-code widget, was wondering if I should create a PR for it?

@justsml justsml deleted the justsml:fix-html-title branch Jan 29, 2018

@lord

This comment has been minimized.

Copy link
Owner

lord commented Jan 29, 2018

Oh wow, really like that interface!

I've been usually not in favor of adding interactive stuff like that, largely because different people using different languages would want very different implementations, and they'll complicate the codebase/make it much more specifically useful for just a single person. So maybe not, but either maintaining a public fork or set of hints/suggestions in the wiki would be better? Thoughts?

@justsml

This comment has been minimized.

Copy link
Contributor Author

justsml commented Feb 4, 2018

Hey @lord Thank you so much, that means a lot to me. ❤️

Are you referring to how runkit only supports NodeJS?

If so, I'm looking into other embedding options to cover more languages:
Also, I believe something like this would only be popular if it was so easy & only required a single <script src='https://some-cdn.com/auto-embed-repl.js'></script>

  • repl.it - Many-lang console

  • stackblitz - just released an embedding API for website oriented examples: Researching it.

  • Some other options I'm trying to figure out require an API key, so I'll reach out to see if a no-setup option is possible...

  • Theming is also something I've been working on - communicating to the live-embeded widget the current styling.

  • Also, the ability to exclude some sections is currently controlled by including a double comment on line 1: //// this wont be auto-enhanced/linked

    • This could be handled in a hidden element containing JSON options. (so zero-coded-config is possible)

I'll release the pkg in the coming weeks - probably announced on twitter.

If you're (or anyone listening) interested, plz follow me on https://twitter.com/justsml

floriandejonckheere added a commit to OpenWebslides/documentation that referenced this pull request Jul 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.