Skip to content

Micah lordnull

  • Lubbock, USA
  • Joined on May 28, 2009

Organizations

OpenACD
lordnull commented on pull request basho/riak_core#609
lordnull commented on pull request basho/riak_test#620
Micah

If the Mod doesn't have a cleanup, this returns false. This means the final run has the possibility to return false even if it succeeded. Recent ch…

lordnull commented on pull request basho/riak_core#609
Micah

Yeah, demonitor w/ flush is a good plan. The eunit test passes. The only case it doesn't cover is if the parent process (the one making the request…

lordnull commented on pull request basho/riak_core#609
Micah

:+1:8cefb59 It took some time for the ensembles to come back, but they do come.

lordnull commented on pull request basho/riak_core#609
lordnull commented on pull request basho/riak_core#609
Micah

Without patch, crash log is full and there's a single ensemble on dev2, no leaders for others. With patch, crash log is empty, no ensembles created…

lordnull commented on pull request basho/riak_kv#997
Micah

:+1:e55adad There is no difference on output, so that would be a successful change.

lordnull commented on pull request basho/riak_ensemble#27
Micah

:+1:02ee10c At least one test will timeout when running the suite, but each test will pass individually, so I don't think the changes in this pr are r…

lordnull commented on pull request basho/riak_ensemble#27
Micah

Had to rebase to get ee to compile. ensemble develop introduced a type that does not exist in this branch. riak_test run: ./riak_test -c ee -t ense…

lordnull commented on pull request basho/riak_ensemble#32
lordnull commented on pull request basho/riak_kv#989
lordnull commented on pull request basho/riak_test#649
Micah

Test fails w/o the ensemble/kv patch, passes with them, so it's a :+1: from me.

lordnull commented on pull request basho/riak_test#649
Micah

Test failed twice when using the appropriate kv and ensemble branches. Test output: https://gist.github.com/lordnull/ca2ee6d88eb0e1fcb095

lordnull commented on pull request basho/riak_test#649
Micah

Might be a good idea to make the sleep duration configurable.

Micah
Micah
  • Micah 5311d17
    Cleaned up cli UI and made it useful as roller.
lordnull commented on pull request basho/bitcask#173
Micah

Looks good (aside from a now out dated comment). Tests pass, code changes appear complete. I enabled coverage, and that's good as well.

lordnull commented on pull request basho/bitcask#173
Micah

This comment is now wrong since the funs are arity 5.

lordnull commented on pull request basho/riak_test#645
Micah

:+1:7d0301d Nicely coded, passes with associated pr's, and fails without.

lordnull commented on pull request basho/riak_kv#990
Micah

:+1:d92ee49 Test fails w/o this, passes with. code is straight forward.

lordnull commented on pull request basho/riak_ensemble#33
Micah

:+1:1464498 Code looks clean and readable, nicely documented callback. associated r_t passes with this (and related) change, fails without.

Micah
  • Micah 08bf5aa
    Added test to ensure ensembles don't start if kv hasn't
lordnull deleted branch bugfix/mw/better-isolate-pb_security-certs at basho/riak_test
Micah
  • Micah c96f318
    Merge pull request #643 from basho/bugfix/mw/better-isolate-pb_securi…
  • Micah f7631b4
    pb_cipher_suites test creates certs in its own dir.
  • 1 more commit »
lordnull merged pull request basho/riak_test#643
Micah
isolate certs created for the pb_security tests.
2 commits with 2 additions and 2 deletions
Micah
  • Micah f7631b4
    pb_cipher_suites test creates certs in its own dir.
lordnull opened pull request basho/riak_test#643
Micah
isolate certs created for the pb_security tests.
1 commit with 1 addition and 1 deletion
Something went wrong with that request. Please try again.