Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take parser out in a separate project #245

Closed
tamtakoe opened this issue Sep 4, 2015 · 5 comments
Closed

Take parser out in a separate project #245

tamtakoe opened this issue Sep 4, 2015 · 5 comments

Comments

@tamtakoe
Copy link

tamtakoe commented Sep 4, 2015

Take parseString out in a separate git/npm project, please

@markstos
Copy link
Collaborator

markstos commented Sep 4, 2015

Closing as a dupe of #181 Note that node-rechoir has this basic functionality already.

@markstos markstos closed this as completed Sep 4, 2015
@markstos
Copy link
Collaborator

markstos commented Sep 4, 2015

@tamtakoe If you prefer exactly how node-config does this over node-rechoir, you are welcome to put the open source license to use and copy the code into a module of your own that you document and publish. Let us know if you get that far, then we'll have an alternative to node-rechoir to consider.

@tamtakoe
Copy link
Author

tamtakoe commented Sep 4, 2015

Why do not you use this node-rechoir?
I found https://github.com/coverslide/node-parse-config but it contains bug
I get use require('config').util.parseString. It works correct but I get some warnings

WARNING: No configurations found in configuration directory:
WARNING: D:\Projects\test\config
WARNING: See https://www.npmjs.org/package/config for more information.

How to disable these warnings?

@markstos
Copy link
Collaborator

markstos commented Sep 4, 2015

Regarding node-rechoir, see the linked #181 ticket for context. Looks like we also considered the interpret module.

Regarding the warning, see https://github.com/lorenwest/node-config/wiki/Environment-Variables#suppress_no_config_warning

Also, searching for the warning in the source code would have quickly found the environment variable used to surpress it.

Further conversation about splitting out the config file loading / parsing can happen in #181 if you are interested.

markstos added a commit that referenced this issue Sep 4, 2015
@tamtakoe
Copy link
Author

tamtakoe commented Sep 4, 2015

I hide warnings, thank! I think I put +1 in #181 :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants