Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Yaml switch #24

Merged
merged 5 commits into from

2 participants

@enyo

Again, as requested, a separate pull request for the yaml parser switch.

I agree with you: it shouldn't break existing users. At the same time: The other yaml parser is just.. better. So if users switch to it, they shouldn't have any problems with their .yaml files.

The only thing they have to do, is to install the other yaml parser.

If you want I can check if there's a nice way to check if either of the yaml modules is installed, thus not braking backwards compatibility.

PS.: I based this pull request on the other one, since you said you wanted to pull it in anyway.

@enyo

Ok.. So I added the Visionmedia YAML parser as fallback if the nodeca parser isn't available.

I haven't found a better way than to simply catch the require() exception.

@enyo

Is there any reason you didn't pull this in yet? Are you not convinced that nodeca's yaml parser is better? Or is there something wrong with my request?

@lorenwest lorenwest merged commit b946411 into lorenwest:v0.4.14
@lorenwest
Owner

Apologies for taking so long to merge this. I'll get a new version published to npm shortly.

@enyo

No problem! I have pending pull requests for weeks sometimes before I have the time to merge them. I just wanted to make sure that everything was OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 27, 2012
  1. @enyo

    Added a test for the environment.

    enyo authored
  2. @enyo
Commits on May 4, 2012
  1. @enyo

    Switching from visionmedia/js-yaml to nodeca/js-yaml.

    enyo authored
    The nodeca parser is a lot more elaborate and stable.
  2. @enyo
Commits on May 7, 2012
  1. @enyo
Something went wrong with that request. Please try again.