HOST and HOSTNAME should take precedence over OS.hostname() #35

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@jscharlach
Contributor

jscharlach commented Oct 16, 2012

As per the docs and comments, HOST and HOSTNAME now take precedence over OS.hostname().

This is necessary so that you can have the same node process running on a server multiple times in 'production' mode but with a differing config via HOST.

Update lib/config.js
HOST and HOSTNAME take precedence over OS.hostname()
@lorenwest

This comment has been minimized.

Show comment
Hide comment
@lorenwest

lorenwest Oct 30, 2012

Owner

Hi @jscharlach, This looks great. Would you mind re-issuing the pull request? It was made against the 0.4.16 branch, and should be made against the 0.4.17 branch. It was my fault for not changing the default branch in the repo.

Thanks,
-Loren

Owner

lorenwest commented Oct 30, 2012

Hi @jscharlach, This looks great. Would you mind re-issuing the pull request? It was made against the 0.4.16 branch, and should be made against the 0.4.17 branch. It was my fault for not changing the default branch in the repo.

Thanks,
-Loren

@lorenwest lorenwest closed this Oct 30, 2012

@lorenwest

This comment has been minimized.

Show comment
Hide comment
@lorenwest

lorenwest Oct 30, 2012

Owner

Oops - I meant 0.4.18. 0.4.17 was already published.

Owner

lorenwest commented Oct 30, 2012

Oops - I meant 0.4.18. 0.4.17 was already published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment