Prevent call of Config.prototype._diffDeep with an undefined argument #43

Merged
merged 1 commit into from Feb 6, 2013

Conversation

Projects
None yet
2 participants
Contributor

codeheroics commented Feb 6, 2013

Config.prototype._diffDeep crashes if called with a value of undefined for the object1 parameter, but the recursive calls of the method could make it happen.

Example code which would have caused a crash :
var obj1 = {a: {}}; var obj2 = {a: {b: {c: 'd'}}}; t._diffDeep(obj1, obj2);

@codeheroics codeheroics Fix error in _diffDeep
Prevent method from being called with an undefined value for object1.
2acce75

lorenwest merged commit 0eff980 into lorenwest:v0.4.18 Feb 6, 2013

Owner

lorenwest commented Feb 6, 2013

Looks good - thanks for the catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment