avoid unnecessary calls to roxygen2::roxygenize() #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #151 +/- ##
==========================================
+ Coverage 64.91% 66.36% +1.44%
==========================================
Files 11 12 +1
Lines 419 440 +21
==========================================
+ Hits 272 292 +20
- Misses 147 148 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea: use {git2r} to check if diff includes roxygen2 comments. This will make the hook pass for all edits that don't involve roxygen comments in
R/and hence bring a big speedup in a typical workflow as the roxygen hook is quite expensive to run. And we have really good testing too of the core functionality.Closes #145.