-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IE9 Functionality Broken #88
Comments
Correction to Original report - the shim now works fine, no errors are reported. I was seeing errors due to something wrong on my end. However functionality is still broken. On your demo page, none of the examples work. Though the "Showing Events" example still displays dispatched events. |
Added pull request #89. The build failed, I'm not sure if it's because of my code changes or the automated babel updates. The tests were passing locally. Please advise |
Is the classlist topic fixed? Than we can close this issue. cheers Max |
I close this issue with the assumption that the classlist shim works fine. cheers Max |
Yup looks good - I wanted to wait to test the updated version before closing myself. Thanks for the quick update. |
The newest (1.6.7) no longer works in IE9 again. Locally I'm seeing a "Symbol is undefined" error on line where lory is initialized. On the demo site, I see a different error saying "Unable to get value of the property 'contains': object is null or undefined." 1.6.6 shows the same errors. Shall I create a new issue or can you reopen this one? cc @levito |
I tried running the demo HTML files in IE9 and I'm getting an error:
This obviously relates to IE9 not supporting classList
if (element.classList.contains(classNameActiveSlide)) {
but including the suggested shim doesn't help either. As far as I can tell, the shim should be able to be included in the page to enable classList functionality, but it doesn't seem to be helping.
Script execution halts when this error is encountered. It looks like the lory HTML is setup correctly, but Forward/Back functionality is broken. I understand that animation is not supported for IE9.
The text was updated successfully, but these errors were encountered: