Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

nobacktick test: Use literal backtick

* Fix sed error on Mac OS, also ignore entire commented lines.
* With proper quoting, the non-POSIX \d96 escape isn't necessary, and the check should work also on Mac OS.
  • Loading branch information...
commit 72fe73f3d8b2ec51e04e86211f5365cb0d551d20 1 parent 8f6070e
@inkarkat inkarkat authored ginatrapani committed
Showing with 2 additions and 1 deletion.
  1. +2 −1  tests/t0100-code-nobacktick.sh
View
3  tests/t0100-code-nobacktick.sh
@@ -5,11 +5,12 @@ test_description='no old-style backtick command substitution
This test checks the todo.sh script itself for occurrences
of old-style backtick command substitution, which should be
replaced with $(...).
+On failure, it will print each offending line number and line.
'
. ./test-lib.sh
test_todo_session 'no old-style backtick command substitution' <<EOF
->>> sed -n -e 's/[ \t]#.*//' -e '/\d96/{=;p}' "$(which todo.sh)"
+>>> sed -n -e 's/\(^\|[ \t]\)#.*//' -e '/\`/{' -e '=;p' -e '}' "$(which todo.sh)"
EOF
test_done
Please sign in to comment.
Something went wrong with that request. Please try again.