Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return tests of `Test` adapter #1147

Merged

Conversation

@AlexWayfer
Copy link
Contributor

@AlexWayfer AlexWayfer commented Apr 17, 2020

Description

I want to improve Test adapter and I found out that tests for it was removed in #939

Todos

List any remaining work that needs to be done, i.e:

  • Tests
  • Documentation
@AlexWayfer
Copy link
Contributor Author

@AlexWayfer AlexWayfer commented Apr 17, 2020

CI fails is not related to this PR.

@AlexWayfer AlexWayfer force-pushed the AlexWayfer:return_tests_of_test_adapter branch from 17646c8 to 12a6c7c Apr 19, 2020
@AlexWayfer
Copy link
Contributor Author

@AlexWayfer AlexWayfer commented Apr 19, 2020

Rebased, CI is green. I need for this PR for #1146

Copy link
Member

@olleolleolle olleolleolle left a comment

Thanks for adding these tests back. LGTM!

@olleolleolle olleolleolle merged commit 87ecaf9 into lostisland:master Apr 20, 2020
6 checks passed
6 checks passed
linting
Details
build (2.4)
Details
build (2.5)
Details
build (2.6)
Details
build (2.7)
Details
codeclimate All good!
Details
@AlexWayfer AlexWayfer deleted the AlexWayfer:return_tests_of_test_adapter branch Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.