Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update `typhoeus` to new stable version (`1.4`) #1159

Merged

Conversation

@AlexWayfer
Copy link
Contributor

@AlexWayfer AlexWayfer commented May 26, 2020

Description

In the title. Released stable versions are better than git-versions.

Todos

List any remaining work that needs to be done, i.e:

  • Tests
  • Documentation
@olleolleolle
Copy link
Member

@olleolleolle olleolleolle commented May 26, 2020

Cool, the build fails on RuboCop, do you think you can make it pass?

@AlexWayfer
Copy link
Contributor Author

@AlexWayfer AlexWayfer commented May 26, 2020

Cool, the build fails on RuboCop, do you think you can make it pass?

I can, but I think it's not related to this PR, and I see you've already created #1160

@olleolleolle
Copy link
Member

@olleolleolle olleolleolle commented May 27, 2020

Thanks, oh, right, I got some energy and got this (linting PR #1160) done at the end of my day.

Copy link
Member

@iMacTia iMacTia left a comment

Thanks @AlexWayfer!
I think we needed this due to a fix merged in master but not released yet. And then of course it went forgotten 😄.

@iMacTia iMacTia merged commit f613099 into lostisland:master May 27, 2020
6 checks passed
6 checks passed
linting
Details
build (2.4)
Details
build (2.5)
Details
build (2.6)
Details
build (2.7)
Details
codeclimate All good!
Details
@AlexWayfer AlexWayfer deleted the AlexWayfer:update_typhoeus_to_new_stable_version branch May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.