Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduces `flat_encode` option for multipart adapter. #1163

Merged
merged 1 commit into from Jul 9, 2020

Conversation

@iMacTia
Copy link
Member

@iMacTia iMacTia commented Jul 8, 2020

Description

Fixes #1157
In the end I opted for an option, as using the encoders would create further complications in case of custom encoders 馃槥

@iMacTia iMacTia force-pushed the fix/multipart-encoder branch from 925c346 to 7b87d46 Jul 9, 2020
@iMacTia iMacTia requested review from technoweenie and olleolleolle Jul 9, 2020
Copy link
Member

@olleolleolle olleolleolle left a comment

Thanks for adding this as an option!

馃憤 LGTM.

(I read the whitespace formatting changes, and found them to be formatting.)

@iMacTia iMacTia merged commit 5acab36 into master Jul 9, 2020
6 checks passed
6 checks passed
linting
Details
build (2.4)
Details
build (2.5)
Details
build (2.6)
Details
build (2.7)
Details
codeclimate All good!
Details
@iMacTia iMacTia deleted the fix/multipart-encoder branch Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can鈥檛 perform that action at this time.