Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly fix test failure with Rack 2.1+. #1171

Merged
merged 1 commit into from Jul 24, 2020

Conversation

@voxik
Copy link
Contributor

@voxik voxik commented Jul 24, 2020

Rack is not to blame, just naive test case which was enough so far.

Fixes #1119

Rack is not to blame, just naive test case which was enough so far.

Fixes #1119
Copy link
Member

@olleolleolle olleolleolle left a comment

The cookie looks just like a cookie, now. A much more readable test!

@olleolleolle olleolleolle merged commit 6521a16 into lostisland:master Jul 24, 2020
6 checks passed
6 checks passed
linting
Details
build (2.4)
Details
build (2.5)
Details
build (2.6)
Details
build (2.7)
Details
codeclimate All good!
Details
@olleolleolle
Copy link
Member

@olleolleolle olleolleolle commented Jul 24, 2020

@voxik Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.