Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include request info in exceptions raised by RaiseError Middleware #1181

Merged
merged 2 commits into from Sep 17, 2020

Conversation

@SandroDamilano
Copy link
Contributor

@SandroDamilano SandroDamilano commented Sep 16, 2020

Description

When using the RaiseError middleware, the error raised contains only information about the response. This should not be a problem if we had just made a single request, or if we caught the error close to where it was raised, so that we can know for sure what the problematic request was. But things can get more tricky if the request was made along with other ones, or as part of a batch process.
When using an error tracker, it's very important to track as much information as we can about the error, so having information about the request as well as the response is critical.
Thus, considering that it would also be very easy for the middleware to include that information, I think it would be a very handy addition.

@iMacTia
Copy link
Member

@iMacTia iMacTia commented Sep 17, 2020

@SandroDamilano thanks for opening this PR. I agree in principle with the changes, however I noticed Rubocop linting is currently failing.
That's not your fault though and I've already fixed it in #1182
Could you please pull/rebase from master and update your PR?

@SandroDamilano
Copy link
Contributor Author

@SandroDamilano SandroDamilano commented Sep 17, 2020

@iMacTia Oh, that's great! I'm on it

@SandroDamilano SandroDamilano force-pushed the rootstrap:master branch from 4ad788d to 868fe9b Sep 17, 2020
…ror_middleware

Include request info in exceptions raised by RaiseError Middleware
@iMacTia iMacTia merged commit 8ee406d into lostisland:master Sep 17, 2020
11 checks passed
11 checks passed
linting
Details
linting
Details
build (2.4)
Details
build (2.4)
Details
build (2.5)
Details
build (2.5)
Details
build (2.6)
Details
build (2.6)
Details
build (2.7)
Details
build (2.7)
Details
codeclimate All good!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.