Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some docs on EventMachine adapters. #1232

Merged
merged 4 commits into from Apr 11, 2021
Merged

Some docs on EventMachine adapters. #1232

merged 4 commits into from Apr 11, 2021

Conversation

@damau
Copy link
Contributor

@damau damau commented Jan 5, 2021

Description

Hey. I spent some time digging through the EM adapters so I thought I would document how to use the parallel bits.

  • Tests - I tested the docs boot up.

Additional Notes

I tried to manage expectations and inform a little on the adapter page. It does behave differently, though obviously for good reason. It's also why I decided not to put parallelization onto the README or front pages.

Also big thanks for all the maintainers. Long time user of Faraday with some time off.

docs/adapters/em-http.md Outdated Show resolved Hide resolved
Copy link
Member

@olleolleolle olleolleolle left a comment

Thanks for improving the docs for these adapters!

I read the change, and only marked a single-letter typo. This is super.

@iMacTia
iMacTia approved these changes Jan 6, 2021
Copy link
Member

@iMacTia iMacTia left a comment

Nicely done and great improvement to the documentation!
We definitely lack knowledge around the EM area and that affects both adapters code and documentation, unfortunately.

We very much welcome the help, and if your "little time off" would allow then we also welcome new maintainers for the adapter that are being moved to external gems 😄
If interested you can read more on this comment

@damau
Copy link
Contributor Author

@damau damau commented Jan 6, 2021

Ta, I'll take a peak.

@iMacTia
Copy link
Member

@iMacTia iMacTia commented Apr 11, 2021

@damau I'm so sorry I have no idea why this wasn't merged yet and I just noticed it!
Thanks again for the this contribution, I'm sure it will help many in future ❤️

@iMacTia iMacTia merged commit 8d379a1 into lostisland:master Apr 11, 2021
7 checks passed
7 checks passed
@github-actions
linting
Details
@github-actions
build 2.4
Details
@github-actions
build 2.5
Details
@github-actions
build 2.6
Details
@github-actions
build 2.7
Details
@github-actions
build 3.0
Details
codeclimate All good!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants