Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NoMethodError undefined method 'coverage' #1255

Merged
merged 2 commits into from Mar 28, 2021

Conversation

@Maroo-b
Copy link
Contributor

@Maroo-b Maroo-b commented Mar 27, 2021

Description

This is a fix for #1254
As mentioned in coveralls-ruby issue: lemurheavy/coveralls-ruby#161, using coveralls-ruby-rebon should fix the problem.

Here is a screenshot from the CI logs as a proof :)
coveralls-logs

Gemfile Outdated
@@ -18,7 +18,7 @@ group :lint, :development do
end

group :test, :development do
gem 'coveralls', require: false
gem 'coveralls_reborn', '~> 0.21.0', require: false

This comment has been minimized.

@olleolleolle

olleolleolle Mar 27, 2021
Member

I think we can allow any version of coveralls_reborn.

This comment has been minimized.

@Maroo-b

Maroo-b Mar 28, 2021
Author Contributor

The fix was only introduced for v "0.21.0" but I removed the explicit version as you recommended.

Copy link
Member

@olleolleolle olleolleolle left a comment

Thanks for setting this up!

@olleolleolle olleolleolle mentioned this pull request Mar 27, 2021
0 of 1 task complete
This is a fix for #1254
As mentioned in coveralls-ruby issue: lemurheavy/coveralls-ruby#161, using coveralls-ruby-rebon should fix the problem.
@Maroo-b Maroo-b force-pushed the Maroo-b:1254_fix_coveralls_issue branch from 91fe134 to 85926af Mar 28, 2021
Copy link
Member

@iMacTia iMacTia left a comment

Thanks for providing the solution! Together with #1256, we should be able to get coveralls back up 🎉

@Maroo-b
Copy link
Contributor Author

@Maroo-b Maroo-b commented Mar 28, 2021

@iMacTia I'm glad that this small fix was helpful. Feel free to share any issue up-for-grabs in this project and I can dedicate some free time to it.

@iMacTia
Copy link
Member

@iMacTia iMacTia commented Mar 28, 2021

We now get the following

Coverage report generated for RSpec to /home/runner/work/faraday/faraday/coverage. 1946 / 2095 LOC (92.89%) covered.
[Coveralls] Submitting to https://coveralls.io/api/v1
[Coveralls] Couldn't find a repository matching this job.
Coverage is at 92.89%.
Coverage report sent to Coveralls.

So it seems reports are now sent correctly to Coveralls 👍!
We can get this merged and look into that "Couldn't find a repository matching this job" separately

@iMacTia iMacTia merged commit 99afc0f into lostisland:master Mar 28, 2021
7 checks passed
7 checks passed
@github-actions
linting
Details
@github-actions
build 2.4
Details
@github-actions
build 2.5
Details
@github-actions
build 2.6
Details
@github-actions
build 2.7
Details
@github-actions
build 3.0
Details
codeclimate All good!
Details
@iMacTia
Copy link
Member

@iMacTia iMacTia commented Mar 28, 2021

@Maroo-b Thanks! I'll send anything that pops in my mind, but for now I'd suggest to look at the "help wanted" and "good first issue" labels in the repo issues 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants