Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Configure the regenerated Coveralls token #1256

Merged
merged 1 commit into from Mar 28, 2021

Conversation

@olleolleolle
Copy link
Member

@olleolleolle olleolleolle commented Mar 27, 2021

This PR adds a Coveralls API token.

Description

I noticed that the last Coveralls code coverage stats was from 2019. Then I found there was a token, and regenerated it. I added it as a GitHub Secret and exposed it to ENV vars in the Action.

See #1254 and its follow-up #1255.

Todos

List any remaining work that needs to be done, i.e:

  • See it work
I noticed that the last Coveralls code coverage stats was from 2019. Then I found there was a token, and regenerated it. I added it as a GitHub Secret and exposed it to ENV vars in the Action.
@olleolleolle olleolleolle requested a review from iMacTia Mar 27, 2021
Copy link
Member

@iMacTia iMacTia left a comment

Thanks @olleolleolle! Merging this one first and hopefully can see it working in #1255

@iMacTia iMacTia merged commit 506954e into master Mar 28, 2021
7 checks passed
7 checks passed
@github-actions
linting
Details
@github-actions
build 2.4
Details
@github-actions
build 2.5
Details
@github-actions
build 2.6
Details
@github-actions
build 2.7
Details
@github-actions
build 3.0
Details
codeclimate All good!
Details
@iMacTia iMacTia deleted the ci-coveralls-token-added-as-secret branch Mar 28, 2021
@olleolleolle
Copy link
Member Author

@olleolleolle olleolleolle commented Mar 29, 2021

@iMacTia I was able to see the commits in the lower half of this page: https://coveralls.io/github/lostisland/faraday The top part of the Coveralls web page seems NOT to reflect the latest changes we have made, BUT that's about their web site, and not what we pass to it.

We got it working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants