Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove codeclimate #1259

Merged
merged 1 commit into from Apr 13, 2021
Merged

Remove codeclimate #1259

merged 1 commit into from Apr 13, 2021

Conversation

@olleolleolle
Copy link
Member

@olleolleolle olleolleolle commented Apr 13, 2021

Description

Since the quality of reporting has gone down, and these fail the
builds, reducing our warning-seeing ability, I now take step of
stopping reporting to CC.

If we want to do any spot-checks, we can run rubycritic, or some other
metrics tool, which does not disrupt our workflow.

Todos

We can do any or all of these:

  • Perhaps remove the now-unused Secret
  • Disable the configured build on CC
  • See if codeclimate is a branch protection thing for merging into our default branch (I removed the webhook)
This removes CodeClimate test reporter ID and badge.

Since the quality of reporting has gone down, and these fail the
builds, reducing our warning-seeing ability, I now take step of
stopping reporting to CC.

If we want to do any spot-checks, we can run rubycritic, or some other
metrics tool, which does not disrupt our workflow.
@olleolleolle olleolleolle force-pushed the remove-codeclimate branch from 2d17187 to 36134c0 Apr 13, 2021
@olleolleolle olleolleolle merged commit 33ee1c4 into master Apr 13, 2021
6 checks passed
6 checks passed
@github-actions
linting
Details
@github-actions
build 2.4
Details
@github-actions
build 2.5
Details
@github-actions
build 2.6
Details
@github-actions
build 2.7
Details
@github-actions
build 3.0
Details
@olleolleolle olleolleolle deleted the remove-codeclimate branch Apr 13, 2021
@olleolleolle olleolleolle mentioned this pull request Apr 13, 2021
0 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant