upgrade to addressable 2.4.0 #42
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is also responsible to crash jekyll-gist on FreeBSD. Would be cool if we can have a new release with addressable 2.4.0. |
|
@mlankenau @fliiiix curious, are you using Octokit.rb? I'm considering folding a simplified version of this project into that project directly, removing a dependency. |
|
Fixed in #44 and released in v0.7.0. |
|
@pengwynn Thanks for the fast response and fix. I'm using jekyll-gist and if I'm not wrong octokit is dependency of it. So a simplified version of octokit would probably prevented this type of issue. |
|
@pengwynn Our dependency chain looks like pronto-octokit-sawyer-addressable. Not sure how pronto is using octokit in detail. |
|
@pengwynn And thx for the fast response :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to include the pronto gem to our project and failed since we have the latest addressable (2.4.0) in use. This is excluded in sawyer. So It would be cool if you can pull and upgrade to 2.4.0.