Add test for validating nested parameters. #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At this point I just have a test but I'll come up with something. I'm not entirely sure wether I need to pick on lotus/validations or stick to lotus/controller. CI will fail since the test is red. |
|
@josemota Thanks for taking care about this, but please don't open incomplete pull requests until we don't have a working implementation. It reduces the overhead for me at this point in time. Thank you. Closing for now, please reopen when ready. Thank you! 👍 |
|
@jodosha Got it. Thanks for taking the time in reviewing it. I'll bring news once I get a working example. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to #53. I'm trying to pick on this issue to see if I learn something. Nested params make absolute sense to be validated.