Allow exception handling to be disabled #6
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default exception handling is very inconvenient while developing and testing a controller as it may hide difficult to spot mistakes behind a very generic 500 error. A solution proposed in #5 would help in development, but not when writing tests.
An afterthought:
handle_exceptions
is very similar to thehandled_exceptions
attribute andhandle_exception
method ofLotus::Action::Throwable
so it may cause unintentional problems with typos. I'll gladly fix the PR if any better name is suggested.