Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button and cell rendering handlers. #28

Merged
merged 4 commits into from Mar 3, 2020
Merged

Add button and cell rendering handlers. #28

merged 4 commits into from Mar 3, 2020

Conversation

@ragnorc
Copy link
Contributor

ragnorc commented Mar 2, 2020

No description provided.

ragnorc added 4 commits Mar 2, 2020
@ragnorc ragnorc changed the title Add button handler and cell rendering handler. Add button and cell rendering handlers. Mar 2, 2020
Copy link

andrewferguson left a comment

Looks good to me. In the same way that we moved away from the fixed offset of 96 to a defined constant, I think it would be good to move away from using raw command types (105, 107, etc...) and move to an enum-like structure that would not only make it easier to change the raw command types, but would also make the code more readable.

However, that's an issue that is seperate from these changes, so I'll approve this PR and those changes can be done later.

@Canbenix Canbenix merged commit db542bb into master Mar 3, 2020
2 checks passed
2 checks passed
Ex3 Linux Ex3 Linux
Details
Ex3 Linux Ex3 Linux
Details
@Canbenix Canbenix deleted the buttons branch Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.