Skip to content

Adds ClickSendSMS notification provider - #798

Merged
louislam merged 5 commits into
louislam:masterfrom
tarun7singh:master
Oct 26, 2021
Merged

Adds ClickSendSMS notification provider#798
louislam merged 5 commits into
louislam:masterfrom
tarun7singh:master

Conversation

@tarun7singh

Copy link
Copy Markdown
Contributor

Description

Adds "Click Send SMS" Notification provider
https://dashboard.clicksend.com/#/dashboard/home

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • User Interface
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Translation update
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and test it
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • My code needed automated testing. I have added them

Screenshots

Screen Shot 2021-10-25 at 12 40 58 PM

@louislam

Copy link
Copy Markdown
Owner

Thanks, did you get any sms screenshot which sent from this feature?

@tarun7singh

Copy link
Copy Markdown
Contributor Author

I have deleted messages from my phone but here's a screenshot from the clickSendDashbaord. But if you still need a message screenshot I'll resend a message.

Screen Shot 2021-10-25 at 2 57 12 PM

@tarun7singh

Copy link
Copy Markdown
Contributor Author

WhatsApp Image 2021-10-25 at 5 32 46 PM

Here's a screenshot of message I sent again.

@Saibamen

Copy link
Copy Markdown
Contributor

Please update only en.js
We will have merge conflicts with #790

@deefdragon

Copy link
Copy Markdown
Contributor

I have decided to speed up and finish the rest of the notification tests tonight so they can be merged. If you could add tests for the NotificationProvider in line with #760 once thats done, that would be great.

@louislam louislam added this to the 1.10.0 milestone Oct 26, 2021
@louislam
louislam merged commit 77addfe into louislam:master Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants