Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

possible fix for issue #68 and #66 and #63 #70

Merged
merged 6 commits into from Feb 19, 2014

Conversation

Projects
None yet
3 participants

as per issue #68 the current implode code in stringable doesn't properly handle punctation/enclitics - i've modified the code to allow nested calls to modify the value being built (otherwise they are always working on an empty string)

this does highlight another issue with the current handling of punctuation - you don't actually want to strip! on all punctuation

Collaborator

rob-at-thewebfellas commented on 65235fb Jan 28, 2014

This should fix this: louismullie#66

i've also added a fix for the rdoc parsing problem in #63

louismullie added a commit that referenced this pull request Feb 19, 2014

@louismullie louismullie merged commit 690157a into louismullie:master Feb 19, 2014

1 check passed

default The Travis CI build passed
Details
Owner

louismullie commented Feb 19, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment