Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set page option for pdf #1595

Merged
merged 1 commit into from Mar 1, 2019

Conversation

Projects
None yet
3 participants
@ramiel
Copy link
Contributor

ramiel commented Mar 1, 2019

The page parameter is considered also when loading a pdf

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 1, 2019

Coverage Status

Coverage remained the same at 99.021% when pulling 689c00e on ramiel:pdf-page-support into 2262959 on lovell:master.

@lovell
Copy link
Owner

lovell left a comment

Thank you for this PR. There's one small addition required relating to the docs but otherwise this looks great!

Show resolved Hide resolved docs/api-constructor.md
Set page option for pdf
Updated docs

@ramiel ramiel force-pushed the ramiel:pdf-page-support branch from a8dc2ba to 689c00e Mar 1, 2019

@lovell

lovell approved these changes Mar 1, 2019

@lovell lovell merged commit 5afe02b into lovell:master Mar 1, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 99.021%
Details

@lovell lovell added this to the v0.22.0 milestone Mar 10, 2019

lovell added a commit that referenced this pull request Mar 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.