Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Implement brightness, saturation and hue modulation #609 #1601
Hello, I've read about feature request #609 because this is what I would like to be able to do too. I have no experience in C/C++ but I followed all advice I could find to stitch those changes.
Can you please look at it and point me to all the missing pieces I should do as well?
Thank you very much!
Thank you very much for this PR Jakub. It looks good from a quick scan and I expect to have some time to take a proper look at it next week.
It's always pleasure to see tests - perhaps try
lovell left a comment
Thanks again for the PR Jakub and apologies for the delay getting around to reviewing this properly.
I've left a couple of comments inline around input validation.
I think the remaining test failures can be resolved by switching to use the lossless PNG format. (There are slight variations in the lossy JPEG decoder on different platforms.)
Yes, I added this file for testing hue rotation https://github.com/lovell/sharp/blob/bed50294bd59fb5f1a22c1edbd98414c85f733c6/test/fixtures/test-pattern.png with hue from 30 to 360 by steps of 30degs. It came exactly as css
Also I had this branch in my app for about a week already and QA didn't find anything wrong with uploaded images.