Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3145] byteOffset of typedArray is not handled properly #3146

Merged
merged 2 commits into from Mar 27, 2022

Conversation

codepage949
Copy link
Contributor

@codepage949 codepage949 commented Mar 19, 2022

Closes #3145

@lovell
Copy link
Owner

@lovell lovell commented Mar 21, 2022

Thank you very much for the PR. Is it possible to add a test for this?

@codepage949
Copy link
Contributor Author

@codepage949 codepage949 commented Mar 22, 2022

@lovell @gacord23 added test.

@lovell
Copy link
Owner

@lovell lovell commented Mar 22, 2022

Thanks for the updates. It looks like this PR was affected by today's GitHub Actions outage as the CI job is still in a queued and non-cancellable state - see https://github.com/lovell/sharp/actions/runs/2021845098

Hopefully the backlog will clear soon and we can get this merged.

@lovell
Copy link
Owner

@lovell lovell commented Mar 26, 2022

It looks like those CI jobs aren't going to run. Please can you rebase against the latest upstream/main branch and push to see if that might be enough to force the tests to run.

@codepage949
Copy link
Contributor Author

@codepage949 codepage949 commented Mar 27, 2022

ok, i did rebase.

@coveralls
Copy link

@coveralls coveralls commented Mar 27, 2022

Coverage Status

Coverage remained the same at 100.0% when pulling bcd7f3a on codepage949:3145-handle-byteoffset into 1d36936 on lovell:main.

@lovell lovell merged commit c3a0d5f into lovell:main Mar 27, 2022
19 checks passed
@lovell
Copy link
Owner

@lovell lovell commented Mar 27, 2022

Thank you!

@lovell lovell added this to the v0.30.4 milestone Mar 27, 2022
lovell added a commit that referenced this issue Mar 28, 2022
martinj pushed a commit to aptoma/sharp that referenced this issue Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants