Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying libc for Linux install #3160

Merged
merged 4 commits into from Apr 28, 2022

Conversation

joonamo
Copy link
Contributor

@joonamo joonamo commented Mar 28, 2022

This is a sibling PR to PR in upstream dependency prebuild-install and should fix #3159.

@joonamo joonamo force-pushed the glibc-on-non-glibc-machine branch from ace1350 to d2c83b0 Compare Apr 22, 2022
@joonamo joonamo force-pushed the glibc-on-non-glibc-machine branch from d2c83b0 to 94b50c3 Compare Apr 22, 2022
@joonamo joonamo marked this pull request as ready for review Apr 22, 2022
@joonamo
Copy link
Contributor Author

@joonamo joonamo commented Apr 22, 2022

@lovell This PR is now ready for review. You can find a test case for darwin and alpine linux in this gist. Let me know if you would need some further verification.

Copy link
Owner

@lovell lovell left a comment

Thank you very much for the PR, I've left one question inline. It might also be worth adding a unit test for overriding npm_config_libc to https://github.com/lovell/sharp/blob/main/test/unit/platform.js for consistency with the other npm_config_* env vars we support.

lib/platform.js Outdated Show resolved Hide resolved
@joonamo joonamo changed the title Read LIBC environment value Allow specifying libc for Linux install Apr 28, 2022
@coveralls
Copy link

@coveralls coveralls commented Apr 28, 2022

Coverage Status

Coverage remained the same at 100.0% when pulling 9703520 on joonamo:glibc-on-non-glibc-machine into d396a4e on lovell:main.

@lovell lovell merged commit 51b4a7c into lovell:main Apr 28, 2022
19 checks passed
@lovell
Copy link
Owner

@lovell lovell commented Apr 28, 2022

Kiitos!

@lovell lovell added this to the v0.30.5 milestone Apr 28, 2022
@joonamo
Copy link
Contributor Author

@joonamo joonamo commented May 24, 2022

Good morning! Was this included in v0.30.5? I can't see it in the changelog 🤔

lovell added a commit that referenced this issue May 24, 2022
@lovell
Copy link
Owner

@lovell lovell commented May 24, 2022

Yes, sorry, I somehow missed adding it to the changelog. It's there now via commit 93b2905 - thanks again Joona for all your work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants