Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing file name to 'Input file is missing' error message #3178

Merged
merged 1 commit into from Apr 5, 2022

Conversation

Brodan
Copy link
Contributor

@Brodan Brodan commented Apr 4, 2022

Fixes #2360

This PR updates the error message 'Input file is missing' to include the file that is missing.

@Brodan
Copy link
Contributor Author

@Brodan Brodan commented Apr 4, 2022

I tested it locally within the module and it seemed to work as expected. However, when I tried to test it in a separate local project I was seeing some weird behavior. I feel like it may have been related to how I was building sharp locally or perhaps I was using npm pack incorrectly.

@coveralls
Copy link

@coveralls coveralls commented Apr 5, 2022

Coverage Status

Coverage remained the same at 100.0% when pulling 7c0a445 on Brodan:main into 5d36f5f on lovell:main.

@lovell lovell merged commit 9deac83 into lovell:main Apr 5, 2022
19 checks passed
@lovell
Copy link
Owner

@lovell lovell commented Apr 5, 2022

This is great, very helpful, thank you Chris.

@lovell lovell added this to the v0.30.4 milestone Apr 5, 2022
lovell added a commit that referenced this issue Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants