From 13678cf45bf257cca6c43e389efdad546cdb66a0 Mon Sep 17 00:00:00 2001 From: Eunchan Kim Date: Tue, 22 Oct 2019 11:10:29 -0700 Subject: [PATCH] [hmac] Add Error Reponse for Read of MSG HMAC MSG FIFO is not a generic memory. It has a range of address space (from offset 0x800 to 0xFFF in a HMAC IP) but all writes to the region fall into a entry in the Message FIFO. The characteristic of the MSG FIFO in the HMAC results in a test failure of DV R/W to the MSG FIFO. Why it tries R/W to the MSG FIFO? well, as it is defined as window in `ip.hjson`, it creates UVM memory model by the tool. So, it needs explict waiver to work around. Now the MSG FIFO has `swaccess` type as `wo`. It shouldn't create the R/W test by default. But it is still useful to notify the software whether it tries to read from the MSG FIFO or not. @tjaychen added a Paramter to `tlul_adapter_sram`. It is `ErrOnRead` to report error on any read request. This paramter value is set to 1 for MSG FIFO now. This is related to #236 --- hw/ip/hmac/rtl/hmac.sv | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/ip/hmac/rtl/hmac.sv b/hw/ip/hmac/rtl/hmac.sv index 450042c966c85..c15f54b5fd42a 100644 --- a/hw/ip/hmac/rtl/hmac.sv +++ b/hw/ip/hmac/rtl/hmac.sv @@ -189,7 +189,8 @@ module hmac ( .SramAw (9), .SramDw (32), .Outstanding (1), - .ByteAccess (1) + .ByteAccess (1), + .ErrOnRead (1) ) u_tlul_adapter ( .clk_i, .rst_ni,