Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[util] Rename vendor_hw.py #607

Open
imphil opened this issue Oct 24, 2019 · 4 comments

Comments

@imphil
Copy link
Collaborator

@imphil imphil commented Oct 24, 2019

The vendor_hw.py script was initially done (as the name says) to vendor in hardware components; it's now used for more than hardware, so we should rename it to a more appropriate name. Possibly vendor.py?

@moidx

This comment has been minimized.

Copy link
Contributor

@moidx moidx commented Nov 15, 2019

vendor.py or vendor_src.py SGTM.

@moidx

This comment has been minimized.

Copy link
Contributor

@moidx moidx commented Nov 15, 2019

Seems like vendor_src is easier to regexp in the future. WDYT @imphil?

I can also update the docs to point to util/vendor. I guess that would also work.

moidx added a commit to moidx/opentitan that referenced this issue Nov 15, 2019
As part of lowRISC#607, rename references from `vendor_hw` to
`util/vendor`. Also, rename `doc/rm/vendor_hw_tool.md` as
`doc/rm/vendor_in_tool.md`.

Signed-off-by: Miguel Osorio <miguelosorio@google.com>
moidx added a commit to moidx/opentitan that referenced this issue Nov 15, 2019
This commit closes issue lowRISC#607.

Signed-off-by: Miguel Osorio <miguelosorio@google.com>
@sjgitty

This comment has been minimized.

Copy link
Contributor

@sjgitty sjgitty commented Nov 15, 2019

vendor_src or vendor_copy sgtm

@sjgitty

This comment has been minimized.

Copy link
Contributor

@sjgitty sjgitty commented Nov 15, 2019

or vendor_in

moidx added a commit to moidx/opentitan that referenced this issue Nov 18, 2019
This commit closes issue lowRISC#607.

Signed-off-by: Miguel Osorio <miguelosorio@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.