HMAC Signoff Checklist #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should've created this as a draft.. Please ignore until the content is ready |
eunchan
commented
Nov 4, 2019
hw/ip/hmac/doc/checklist.md
Outdated
| Code Quality | [CDC_COMPLETE][] | N/A | | ||
| Review | [REVIEW_RTL][] | In Progress | @tjaychen | ||
| Review | [REVIEW_DELETED_FF][] | N/A | | ||
| Review | [REVIEW_SW_CSR][] | Not Started | @moidx |
There was a problem hiding this comment.
@moidx Could you please check if below two items can be reviewed today?
There was a problem hiding this comment.
LGTM. Reviewed both SW_CSR and SW_FATAL_ERR.
eunchan
commented
Nov 4, 2019
| Type | Item | Resolution | Note/Collaterals | ||
| --------------|-----------------------------------|-------------|------------------ | ||
| Documentation | [DESIGN_DELTAS_CAPTURED_IF_ANY][] | N/A | | ||
| Testbench | [ALL_TODOS_RESOLVED][] | Done | [issue #385][] item 3 not related / Resolved: [pr #749][] |
There was a problem hiding this comment.
@cindychip I changed this to Done state as issue #385 item 3 isn't applicable to the launch.
eunchan
commented
Nov 4, 2019
eunchan
commented
Nov 4, 2019
|
Hi Eunchan,
Thanks for asking, the exclusion file is under review here:
#820
Could you take a look when you have a min?
THanks,
CIndy
…On Mon, Nov 4, 2019 at 11:35 AM Eunchan Kim ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In hw/ip/hmac/doc/checklist.md
<#678 (comment)>:
> +[CODE_COVERAGE_V2]: {{<relref "/doc/rm/checklist.md#code-coverage-v2" >}}
+[FUNCTIONAL_COVERAGE_V2]: {{<relref "/doc/rm/checklist.md#functional-coverage-v2" >}}
+[NO_HIGH_PRIORITY_ISSUES_PENDING]: {{<relref "/doc/rm/checklist.md#no-high-priority-issues-pending" >}}
+[ALL_LOW_PRIORITY_ISSUES_ROOT_CAUSED]:{{<relref "/doc/rm/checklist.md#all-low-priority-issues-root-caused" >}}
+[PRE_VERIFIED_SUB_MODULES_V2]: {{<relref "/doc/rm/checklist.md#pre-verified-sub-modules-v2" >}}
+[V3_CHECKLIST_SCOPED]: {{<relref "/doc/rm/checklist.md#v3-checklist-scoped" >}}
+
+### V3
+
+ Type | Item | Resolution | Note/Collaterals
+--------------|-----------------------------------|-------------|------------------
+Documentation | [DESIGN_DELTAS_CAPTURED_IF_ANY][] | N/A |
+Testbench | [ALL_TODOS_RESOLVED][] | Done | [issue #385][] item 3 not related / Resolved: [pr #749][]
+Tests | [X_PROP_ANALYSIS_COMPLETED][] | Waived |
+Regression | [NIGHTLY_REGRESSION_AT_100][] | Done |
+Coverage | [CODE_COVERAGE_AT_100][] | In Progress | prim_fifo_sync revised [common_cov_excl.el][] HMAC excl to be added
@cindychip <https://github.com/cindychip> Could you please give me an
update on this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#678?email_source=notifications&email_token=ACXPOOPM5YF5Z4XWRXRICTTQSB2Q5A5CNFSM4JGOYGKKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKHDCEA#pullrequestreview-311308560>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACXPOOPQNJPEAWFQSWHRBQ3QSB2Q5ANCNFSM4JGOYGKA>
.
|
moidx
reviewed
Nov 4, 2019
hw/ip/hmac/doc/checklist.md
Outdated
| [REVIEW_DBG]: {{<relref "/doc/rm/checklist.md#review-dbg" >}} | ||
| [REVIEW_DELETED_FF]: {{<relref "/doc/rm/checklist.md#review-deleted-ff" >}} | ||
| [REVIEW_SW_CSR]: {{<relref "/doc/rm/checklist.md#review-sw-csr" >}} | ||
| [REVIEW_SW_FATAL_ERR]: {{<relref "/doc/rm/checklist.md#review-sw-fatal-err" >}} |
There was a problem hiding this comment.
Noticed that these links use underscore in the checked-in version:
Suggested change
| [REVIEW_SW_FATAL_ERR]: {{<relref "/doc/rm/checklist.md#review-sw-fatal-err" >}} | |
| [REVIEW_SW_FATAL_ERR]: {{<relref "/doc/rm/checklist.md#review_sw_fatal_err" >}} |
There was a problem hiding this comment.
Hugo heading style let it be hyphen rather than underscore..
sjgitty
reviewed
Nov 4, 2019
sjgitty
reviewed
Nov 4, 2019
sjgitty
reviewed
Nov 4, 2019
cindychip
reviewed
Nov 5, 2019
hw/ip/hmac/doc/checklist.md
Outdated
| title: "HMAC Checklist" | ||
| --- | ||
|
|
||
| This checklist is for [Hardware Stage]({{<relref "/doc/ug/hw_stages.md" >}}) |
There was a problem hiding this comment.
Hi Eunchan, I am having trouble pushing to your forked branch, but I think all the path below need to update to /doc/project/hw_stages.md
cindychip
approved these changes
Nov 5, 2019
sjgitty
approved these changes
Nov 5, 2019
Revised items arouse in the signoff meeting. - Remove any TODOs in the design and go through RFC if new features are needed - Add exclusion file link to the checklist doc Co-authored-by: Cindy Chen <chencindy@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.