Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otbn,dv] Add a handy wrapper to run lots of Verilated tests #8107

Merged
merged 1 commit into from Sep 9, 2021

Conversation

rswarbrick
Copy link
Contributor

This is a "pre-dv-only" thing, but it's a darn sight faster than
running VCS. Example usage:

hw/ip/otbn/dv/verilator/run-some.py --size=1500 --count=10 XXX

@rswarbrick rswarbrick added Component:DV DV issue: testbench, test case, etc. Type:Enhancement Feature requests, enhancements Component:OTBN labels Sep 8, 2021
@rswarbrick rswarbrick added this to In review in DEPRECATED - OTBN Development via automation Sep 8, 2021
@sriyerg
Copy link
Contributor

sriyerg commented Sep 8, 2021

FYI, DVSim already supports Verilator. Here's the hjson config file for the chip level:
https://github.com/lowRISC/opentitan/blob/master/hw/top_earlgrey/dv/verilator/verilator_sim_cfg.hjson

@rswarbrick
Copy link
Contributor Author

That would probably work well if someone improves the dvsim scheduler to be able to run a job in less than a second. As it is, I suspect running ninja (or make) directly is massively quicker for examples like this where each job takes a very short time.

When dvsim is faster, I'd be very happy to revisit this! Until then, getting this working took half an hour and has already saved me time. I think we should merge this as a stop-gap.

@sriyerg
Copy link
Contributor

sriyerg commented Sep 8, 2021

That would probably work well if someone improves the dvsim scheduler to be able to run a job in less than a second. As it is, I suspect running ninja (or make) directly is massively quicker for examples like this where each job takes a very short time.

When dvsim is faster, I'd be very happy to revisit this! Until then, getting this working took half an hour and has already saved me time. I think we should merge this as a stop-gap.

I agree quite a few parts of DVSim are still inefficient. However, it will be great to see quantitative data showing how slow DVSim really is, rather than make assumptions. Would you please add a short README explaining what / how are tests run? I would like to take a stab at porting this over to DVSim (later, when I have the time). For now, feel free to proceed with this.

This is a "pre-dv-only" thing, but it's a darn sight faster than
running VCS. Example usage:

    hw/ip/otbn/dv/verilator/run-some.py --size=1500 --count=10 XXX

Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
@rswarbrick rswarbrick merged commit 5c7b601 into lowRISC:master Sep 9, 2021
DEPRECATED - OTBN Development automation moved this from In review to Done Sep 9, 2021
@rswarbrick rswarbrick deleted the otbn-veri branch September 9, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:DV DV issue: testbench, test case, etc. Type:Enhancement Feature requests, enhancements
Development

Successfully merging this pull request may close these issues.

None yet

3 participants