Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rv_dm] Address Verilator lint warnings #21716

Closed
rswarbrick opened this issue Feb 27, 2024 · 3 comments
Closed

[rv_dm] Address Verilator lint warnings #21716

rswarbrick opened this issue Feb 27, 2024 · 3 comments

Comments

@rswarbrick
Copy link
Contributor

Description

The nightly lint check for rv_dm contains 5 warnings.

It looks like 4 of these are width bugs in the vendored code. No big deal, but probably worth waiving in a .vlt file. There's also an UNOPTFLAT warning about tlul_lc_gate.sv, which we wrote. Address it.

See https://reports.opentitan.org/hw/ip/rv_dm/lint/verilator/latest/report.html for the latest report.

@rswarbrick
Copy link
Contributor Author

The two PRs linked in above should fix this. I don't think I know how to use PR links to say "please close this issue when both PRs have been merged", so we might have to do it manually... :-)

@rswarbrick
Copy link
Contributor Author

The remaining portion of this is fixed by #22486 (but I don't seem to be able to create the links through GitHub that would put this in the "development" box on the right)

@andreaskurth
Copy link
Contributor

Closing as completed by #21736 and #22486.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants